Added support for client certificates (#1063) #1076
Conversation
Issue: #1030 # why Allowing authentication using provided client certificates during local runs. # what changed Additional configuration value 'clientCertificates' that's being passed during Playwright context creation. # test plan This is additional support for already existing Playwright feature so Playwright team's internal test for this feature should be enough. But to test locally, provide client certificate config according to this API - https://playwright.dev/docs/api/class-browser#browser-new-context-option-client-certificates - and authenticate to whichever service that certificate belongs to.
🦋 Changeset detectedLatest commit: 44a2760 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR adds support for client certificates in local browser environments by introducing a new clientCertificates configuration option. The implementation follows Playwright's native client certificate API, allowing users to authenticate with services that require client certificate authentication during local test runs.
• Added clientCertificates property to LocalBrowserLaunchOptions interface with comprehensive certificate format support
• Integrated client certificates into the browser context creation in getBrowser function
• Created appropriate changeset marking this as a major version change
• Removed export of deprecated AISdkClient from main index
Confidence score: 4/5
- This PR is safe to merge with minimal risk
- The implementation is straightforward, follows Playwright's native API exactly, and only adds optional functionality without breaking existing behavior. The type definitions are comprehensive and the integration is clean.
- No files require special attention
2 files reviewed, no comments
Contrib from @Samat-Imamov
Issue: #1030
why
Allowing authentication using provided client certificates during local runs.
what changed
Additional configuration value 'clientCertificates' that's being passed during Playwright context creation.
test plan
This is additional support for already existing Playwright feature so Playwright team's internal test for this feature should be enough. But to test locally, provide client certificate config according to this API -
https://playwright.dev/docs/api/class-browser#browser-new-context-option-client-certificates